test(fix): remove assertion on error message for reads older than 60 seconds #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
commented
Jun 18, 2021
| final Status status = invalidArgument.getStatus(); | ||
| assertThat(status.getCode()).isEqualTo(Code.FAILED_PRECONDITION); | ||
| assertThat(status.getDescription()).contains("minimum"); | ||
| assertThat(status.getDescription()).isEqualTo("The requested snapshot version is too old."); |
Collaborator
Author
There was a problem hiding this comment.
Question to reviewer: I noticed we've updated this assertion before - is it worth keeping (is the previous assertion enough?)
Contributor
There was a problem hiding this comment.
I think we can just delete this line, checking for exact messages does not bring much value and is easy to break.
Collaborator
Author
There was a problem hiding this comment.
Thanks @wu-hui, I've removed the assertion.
wu-hui
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the error message for this has been updated.