Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Jun 21, 2024

Following the suggestions made here from the Protobuf team: #1692 (comment)

Converting the handwritten code from AbstractMessage to Message for Protobuf 4.x compatibility.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels Jun 21, 2024
@lqiu96 lqiu96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2024
@lqiu96 lqiu96 marked this pull request as ready for review June 21, 2024 19:13
@lqiu96 lqiu96 requested a review from a team as a code owner June 21, 2024 19:13
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 21, 2024 19:14
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2024
@lqiu96 lqiu96 merged commit 50c79d4 into main Jun 27, 2024
@lqiu96 lqiu96 deleted the pbj426-compatibility branch June 27, 2024 19:56
Copy link

@googleberg googleberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants