fix: correct FirestoreAdminClient source link in documentation#2304
Merged
jinseopkim0 merged 2 commits intomainfrom Feb 4, 2026
Merged
fix: correct FirestoreAdminClient source link in documentation#2304jinseopkim0 merged 2 commits intomainfrom
jinseopkim0 merged 2 commits intomainfrom
Conversation
Contributor
|
this .repo-metadata.json file is re-generated from scratch every time hermetic build runs. As you see in 1251109 it reverted your changes. |
The FirestoreAdminClient source code resides in the `google-cloud-firestore-admin` directory, which differs from the artifact ID (`google-cloud-firestore`). This mismatch causes the generated GitHub source links in the documentation to be broken. This change adds `library_path_overrides` to `.repo-metadata.json` to explicitly map `FirestoreAdminClient` to the correct source directory. Fixes: b/442875200
1251109 to
2e567b2
Compare
Contributor
Author
Thanks for the feedback. I've updated owlbot.py to inject the needed override, and the |
zhumin8
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FirestoreAdminClient source code resides in the
google-cloud-firestore-admindirectory, which differs from the artifact ID (google-cloud-firestore). This mismatch causes the generated GitHub source links in the documentation to be broken.This change updates
owlbot.pyto injectlibrary_path_overridesinto.repo-metadata.json. This configuration explicitly mapsFirestoreAdminClientto the correct source directory (google-cloud-firestore-admin). Modifyingowlbot.pyensures this fix persists across future regenerations of the library.Fixes: b/442875200