Skip to content

fix: flaky test com.google.datastore.snippets.ConceptsTest: testStale… #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 3 commits into from
Mar 8, 2023
Merged

fix: flaky test com.google.datastore.snippets.ConceptsTest: testStale… #1012

gcf-merge-on-green merged 3 commits into from
Mar 8, 2023

Conversation

@jainsahab
Copy link
Contributor

@jainsahab jainsahab commented Mar 8, 2023 •
edited by kolea2
Loading

BEGIN_COMMIT_OVERRIDE
samples: fix flakiness in ConceptsTest: testStaleReads
END_COMMIT_OVERRIDE
Fixes #905 ☕️

Please follow the explanation in comment #905 (comment).

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. labels Mar 8, 2023
@jainsahab jainsahab added owlbot:run Add this label to trigger the Owlbot post processor. automerge Merge the pull request once unit tests and other checks pass. labels Mar 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2023
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners March 8, 2023 16:19
@gcf-merge-on-green gcf-merge-on-green bot merged commit fc66d58 into googleapis:main Mar 8, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2023
@release-please release-please bot mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

com.google.datastore.snippets.ConceptsTest: testStaleReads failed

2 participants

@jainsahab @kolea2