Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Apr 26, 2022

  • Regenerate this pull request now.

PiperOrigin-RevId: 454027580

Source-Link: googleapis/googleapis@1b22277

Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9

chore(deps): upgrade gapic-generator-java to 2.8.0 and update gax-java to 2.18.1
PiperOrigin-RevId: 450543911

Source-Link: googleapis/googleapis@5528344

Source-Link: https://github.com/googleapis/googleapis-gen/commit/9f6775cab1958982b88967a43e5e806af0f135db
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWY2Nzc1Y2FiMTk1ODk4MmI4ODk2N2E0M2U1ZTgwNmFmMGYxMzVkYiJ9

chore(deps): upgrade gapic-generator-java to 2.7.0 and update gax-java to 2.16.0

PiperOrigin-RevId: 446250659

Source-Link: googleapis/googleapis@dc4ef31

Source-Link: https://github.com/googleapis/googleapis-gen/commit/5fdda4ddfbab87998e77e4a453e0ff87986d2db8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWZkZGE0ZGRmYmFiODc5OThlNzdlNGE0NTNlMGZmODc5ODZkMmRiOCJ9

chore(bazel): update version of Protobuf to v3.20.1

PiperOrigin-RevId: 444328399

Source-Link: googleapis/googleapis@c7ca416

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d61705453a62b3ecda78aa30c192840ebc5a8a90
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDYxNzA1NDUzYTYyYjNlY2RhNzhhYTMwYzE5Mjg0MGViYzVhOGE5MCJ9

@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners April 26, 2022 02:06
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 26, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: container Issues related to the googleapis/java-container API. labels Apr 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 26, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Apr 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2022
suztomo
suztomo previously approved these changes Apr 28, 2022
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Apr 28, 2022
@suztomo
Copy link
Member

suztomo commented Apr 28, 2022

???

Error:  /home/runner/work/java-container/java-container/google-cloud-container/src/test/java/com/google/cloud/container/v1/it/ITSystemTest.java:[64,5] cannot find symbol
  symbol:   variable Util
  location: class com.google.cloud.container.v1.it.ITSystemTest

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2022
@Shabirmean
Copy link
Contributor

???

Error:  /home/runner/work/java-container/java-container/google-cloud-container/src/test/java/com/google/cloud/container/v1/it/ITSystemTest.java:[64,5] cannot find symbol
  symbol:   variable Util
  location: class com.google.cloud.container.v1.it.ITSystemTest

@suztomo - this seems like a significant overhaul. Is is common that we merge changes like this at once into the library?

@suztomo suztomo dismissed their stale review April 29, 2022 15:43

build failing.

@suztomo
Copy link
Member

suztomo commented Apr 29, 2022

@Shabirmean No, we don't merge pull requests failing builds.

It's strange that a change like this cl/444328399 (not touching proto files) failing Java code, and this is only change written by Owl Bot.

@suztomo
Copy link
Member

suztomo commented Apr 29, 2022

I just filed a bug report to Owl Bot. googleapis/repo-automation-bots#3534

@Neenu1995
Copy link
Contributor

Hi,
Owlbot is behaving as expected. Util.java is a recently added handwritten file. Owlbot will remove any handwritten files unless it is added to an exclusion list.

The solution is to re-add the file and add it to the exclusion list. @Shabirmean would you assign it to somebody in the anthos-dpe team?

@Neenu1995
Copy link
Contributor

Neenu1995 commented May 2, 2022

About the other file changes, since the source of this PR is a protobuf update in the generator, it is expected.

@suztomo
Copy link
Member

suztomo commented May 2, 2022

@Neenu1995 Thank you for diagnosis.

@gcf-owl-bot gcf-owl-bot bot changed the title chore(bazel): update version of Protobuf to v3.20.1 chore(deps): upgrade gapic-generator-java to 2.7.0 and update gax-java to 2.16.0 May 3, 2022
@product-auto-label product-auto-label bot removed the size: l Pull request size is large. label May 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jun 10, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2022
@Shabirmean Shabirmean added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2022
@eaball35 eaball35 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 15, 2022
@Shabirmean Shabirmean added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 20, 2022
@meltsufin meltsufin added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jun 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2022
@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 24, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 25, 2022
@blakeli0 blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 28, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 29, 2022
@blakeli0 blakeli0 merged commit 0f2da87 into main Jun 29, 2022
@blakeli0 blakeli0 deleted the owl-bot-copy branch June 29, 2022 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: container Issues related to the googleapis/java-container API. owl-bot-copy size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants