Skip to content

fix: add error handling to get-service-names.sh #7001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhumin8 merged 1 commit into from
Mar 27, 2025
Merged

fix: add error handling to get-service-names.sh #7001

zhumin8 merged 1 commit into from
Mar 27, 2025

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Mar 27, 2025 •
edited
Loading

This script lacked error handling, causing it to fail when modules like java-marketingplatformadminapi
See context in doc

This fix is manually tested and can get a peek of data with

SELECT * FROM `cloud-java-metrics.client_library_versions.cloud_java_client_library_release_dates` 
WHERE TIMESTAMP_TRUNC(_PARTITIONTIME, DAY) = TIMESTAMP("2025-03-27") LIMIT 1000

For longer term, consider adding tests and/or refactoring.

@zhumin8 zhumin8 requested a review from a team as a code owner March 27, 2025 17:46
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 27, 2025
@zhumin8 zhumin8 merged commit cfc7ea2 into main Mar 27, 2025
24 checks passed
@zhumin8 zhumin8 deleted the fix-get-versions branch March 27, 2025 19:26
@release-please release-please bot mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhumin8 @diegomarquezp