feat: add future delete handling #3521
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vermas2012
requested changes
Feb 28, 2022
| long currTime = EnvironmentEdgeManager.currentTime(); | ||
|
|
||
| // test if delete is in future timestamp | ||
| if (CellUtil.isDelete(cell) && cell.getTimestamp() > currTime) { |
Member
There was a problem hiding this comment.
This does not sound right, we should check with WalWriteTime. In case of large replication delay, currentTime and WAL write time will differ, we want to make sure that delete was issued in future.
| + cell.getTimestamp() | ||
| + "current time: " | ||
| + currTime); | ||
| throw new UnsupportedOperationException("Unsupported future delete: " + cell); |
Member
There was a problem hiding this comment.
This is not right, We do support future deletes. The issue with future deletes is around behavior of DeleteRow. We should not try to "fix" anything here. but just flag the potential change of behavior.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add incompatible mutation/dropped mutations for deletes at future timestamp