chore(test): improve resource handling in tests #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
igorbernstein2
commented
May 7, 2021
- fix resource cleanup: time based resource cleanup expected a prefix followed by a number, but some tests inserted a string in between which would prevent clean. Now all prefixes are generated in a single place
- fix cleanup contention: concurrent tests will try to cleanup resources at the same time. Mitigate this by swallowing not found error
- fix concurrent test runs: the prefix was based on time only, which would causes tests running in the same second to clobber each other
- optimize backup test to only create a single new instance
* fix resource cleanup: time based resource cleanup expected a prefix followed by a number, but some tests inserted a string in between which would prevent clean. Now all prefixes are generated in a single place * fix cleanup contention: concurrent tests will try to cleanup resources at the same time. Mitigate this by swallowing not found error * fix concurrent test runs: the prefix was based on time only, which would causes tests running in the same second to clobber each other * optimize backup test to only create a single new instance
liubonan
reviewed
May 7, 2021
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableBackupIT.java
Show resolved
Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableBackupIT.java
Outdated
Show resolved
Hide resolved
kolea2
suggested changes
May 7, 2021
...cloud-bigtable/src/test/java/com/google/cloud/bigtable/test_helpers/env/AbstractTestEnv.java
Show resolved
Hide resolved
...cloud-bigtable/src/test/java/com/google/cloud/bigtable/test_helpers/env/AbstractTestEnv.java
Outdated
Show resolved
Hide resolved
...cloud-bigtable/src/test/java/com/google/cloud/bigtable/test_helpers/env/AbstractTestEnv.java
Show resolved
Hide resolved
kolea2
approved these changes
May 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
============================================
- Coverage 83.47% 83.46% -0.02%
Complexity 1315 1315
============================================
Files 114 114
Lines 7806 7806
Branches 446 446
============================================
- Hits 6516 6515 -1
- Misses 1034 1036 +2
+ Partials 256 255 -1
Continue to review full report at Codecov.
|
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.