Skip to content

feat: dynamic flow control for bulk mutation batcher #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mutianf wants to merge 3 commits into from
Closed

feat: dynamic flow control for bulk mutation batcher #612

mutianf wants to merge 3 commits into from

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Feb 4, 2021

Implementation of go/veneer-dynamic-flow-control
Will split this PR into smaller chunks. And it depends on googleapis/gax-java#1288.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@mutianf mutianf added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 4, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Feb 4, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #612 (bbb9109) into master (527e897) will decrease coverage by 22.52%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #612       +/-   ##
=============================================
- Coverage     81.72%   59.20%   -22.53%     
+ Complexity     1152       19     -1133     
=============================================
  Files           109        2      -107     
  Lines          7192      125     -7067     
  Branches        376       18      -358     
=============================================
- Hits           5878       74     -5804     
+ Misses         1117       34     -1083     
+ Partials        197       17      -180
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/bigtable/emulator/v2/Emulator.java 56.52% <0.00%> (-3.32%) 14.00% <0.00%> (ø%)
...oogle/cloud/bigtable/admin/v2/models/Instance.java
...v2/stub/mutaterows/MutateRowsRetryingCallable.java
.../bigtable/admin/v2/models/RestoreTableRequest.java
...bigtable/data/v2/stub/metrics/CompositeTracer.java
...ud/bigtable/data/v2/BigtableDataClientFactory.java
...able/data/v2/stub/metrics/RpcMeasureConstants.java
...gle/cloud/bigtable/data/v2/internal/RegexUtil.java
...gle/cloud/bigtable/data/v2/models/RowMutation.java
.../com/google/cloud/bigtable/data/v2/models/Row.java
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527e897...32d3a90. Read the comment docs.

@mutianf mutianf mentioned this pull request Feb 8, 2021
Merged
4 tasks
@mutianf
Copy link
Contributor Author

mutianf commented Mar 30, 2021

Changes are merged into dynamic_flow_control branch.

@mutianf mutianf closed this Mar 30, 2021
@mutianf mutianf deleted the dynamic_flow_control branch March 30, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mutianf