Skip to content

chore: better error message when metric publish failed#2214

Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
mutianf:logging
Apr 26, 2024
Merged

chore: better error message when metric publish failed#2214
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
mutianf:logging

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Apr 26, 2024

Also reduces logging when there are continuous failures (like permission denied).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team April 26, 2024 13:57
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Apr 26, 2024
@igorbernstein2 igorbernstein2 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024
@mutianf mutianf requested a review from a team April 26, 2024 19:33
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4d92e1c into googleapis:main Apr 26, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 26, 2024
@mutianf mutianf deleted the logging branch April 26, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants