chore: java doc update to for returned data instances #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
reviewed
Jan 23, 2020
Contributor
kolea2
left a comment
There was a problem hiding this comment.
Can we also add an issue for this in gax to update the Batcher interface?
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
Outdated
Show resolved
Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
Outdated
Show resolved
Hide resolved
Contributor
|
also - conventional commits check is failing I believe because there is not a space between |
To let the user know about Batcher instance returned from Bulk operations are not threadsafe.
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
Coverage ? 81.92%
Complexity ? 971
=========================================
Files ? 99
Lines ? 6021
Branches ? 330
=========================================
Hits ? 4933
Misses ? 910
Partials ? 178
Continue to review full report at Codecov.
|
Added JavaDocs for `BigtableDataClient`.
Contributor
Author
|
Thanks for the review, I have addressed previous comments, Please have a fresh look. |
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
Show resolved
Hide resolved
Contributor
igorbernstein2
left a comment
There was a problem hiding this comment.
Looks good, but readRows needs a note as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114