This repository was archived by the owner on May 8, 2026. It is now read-only.
test: attempt to fix flaky test#1584
Merged
Merged
Conversation
Comment on lines
72
to
77
| // give opencensus some time to populate view data | ||
| Thread.sleep(100); | ||
| Thread.sleep(1000); | ||
|
|
||
| List<String> tagValueStrings = StatsWrapper.getOperationLatencyViewTagValueStrings(); | ||
| assertThat(tagValueStrings).contains(clusters.get(0).getZone()); | ||
| assertThat(tagValueStrings).contains(clusters.get(0).getId()); |
Contributor
There was a problem hiding this comment.
I dont love blindly extending sleeps. Can we switch this to polling instead?
for(int i=0; i<10;i++) {
if(StatsWrapper.getOperationLatencyViewTagValueStrings()).contains(clusters.get(0).getId()) {
break;
}
List<String> tagValueStrings = StatsWrapper.getOperationLatencyViewTagValueStrings();
assertThat(tagValueStrings).contains(clusters.get(0).getZone());
assertThat(tagValueStrings).contains(clusters.get(0).getId());
}
same for below
igorbernstein2
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnaryMetricsMetadataIT: testFailure sometimes fails with:
Setting a longer wait time before checking opencensus stats. Also assign the returned value to a future.
DynamicFlowControlCallableTest sometimes fails with:
Cleanup DyanmicFlowControlStats after each test, and create a new Stats instance and callable inside the testLatenciesAreRecorded test.