Skip to content

test(fix): update the test proxy's pom file to build a shaded jar, also correct the README about building an old version#1546

Merged
liujiongxin merged 5 commits intogoogleapis:mainfrom
liujiongxin:fix_proxy
Dec 12, 2022
Merged

test(fix): update the test proxy's pom file to build a shaded jar, also correct the README about building an old version#1546
liujiongxin merged 5 commits intogoogleapis:mainfrom
liujiongxin:fix_proxy

Conversation

@liujiongxin
Copy link
Contributor

…so correct the README about building an old version

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

…so correct the README about building an old version
@liujiongxin liujiongxin requested review from a team December 12, 2022 17:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 12, 2022
…so correct the README about building an old version
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Dec 12, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 12, 2022
@liujiongxin liujiongxin added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 12, 2022
@liujiongxin liujiongxin merged commit 431928e into googleapis:main Dec 12, 2022
@liujiongxin liujiongxin deleted the fix_proxy branch December 20, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants