chore(deps): add grpc-google-common-protos to the deps bom #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used by this client, but this client uses proto-google-common-protos, and the hbase adapter uses grpc-google-common-protos. So we will use the deps bom to align the 2. Ideally we would use google-common-protos-bom, but that doesn't exists
kolea2
approved these changes
Jan 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
============================================
- Coverage 81.74% 81.72% -0.02%
Complexity 952 952
============================================
Files 97 97
Lines 5927 5927
Branches 327 327
============================================
- Hits 4845 4844 -1
- Misses 904 905 +1
Partials 178 178
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not used by this client, but this client uses proto-google-common-protos,
and the hbase adapter uses grpc-google-common-protos. So we will use the deps
bom to align the 2. Ideally we would use google-common-protos-bom, but that doesn't
exists
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)