Skip to content

Conversation

@igorbernstein2
Copy link
Contributor

  • expand google-cloud-core to a bom, so that we fix google-cloud-core-http's version in the hbase adapter
  • google-http-client-bom, it's a transitive dep for google-cloud-bigtable and a direct dep of the hbase adaptor
  • opencensus-* add a bunch more relevant opencensus deps. There is no opencensus-bom, so we enumerate any that might be useful

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

* expand google-cloud-core to a bom, so that we fix google-cloud-core-http's version in the hbase adapter
* google-http-client-bom, it's a transitive dep for google-cloud-bigtable and a direct dep of the hbase adaptor
* opencensus-* add a bunch more relevant opencensus deps. There is no opencensus-bom, so we enumerate any that might be useful
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@dfbd4ed). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #143   +/-   ##
=========================================
  Coverage          ?   81.74%           
  Complexity        ?      952           
=========================================
  Files             ?       97           
  Lines             ?     5927           
  Branches          ?      327           
=========================================
  Hits              ?     4845           
  Misses            ?      904           
  Partials          ?      178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbd4ed...2b435e4. Read the comment docs.

@igorbernstein2 igorbernstein2 marked this pull request as ready for review January 9, 2020 16:40
@igorbernstein2 igorbernstein2 changed the title chore(deps): add a few missing artifacts to the deps bom deps: add a few missing artifacts to the deps bom Jan 9, 2020
@igorbernstein2 igorbernstein2 requested a review from kolea2 January 9, 2020 16:40
@igorbernstein2 igorbernstein2 merged commit df7082b into googleapis:master Jan 9, 2020
@igorbernstein2 igorbernstein2 deleted the bom-fixes branch January 9, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants