Skip to content

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Jan 7, 2020

The checkstyle settings in our pom.xml were added to the shared config and can now be deleted here.

Also some minor whitespace reformatting

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2020
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@dfbd4ed). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #141   +/-   ##
=========================================
  Coverage          ?   81.72%           
  Complexity        ?      952           
=========================================
  Files             ?       97           
  Lines             ?     5927           
  Branches          ?      327           
=========================================
  Hits              ?     4844           
  Misses            ?      905           
  Partials          ?      178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbd4ed...ed9429b. Read the comment docs.

@kolea2 kolea2 requested a review from igorbernstein2 January 8, 2020 22:43
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kolea2 kolea2 merged commit df37b65 into googleapis:master Jan 8, 2020
@kolea2 kolea2 deleted the pom-checkstyle branch January 8, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants