Skip to content

MetricTracer should not throw exceptions and hang the request when the request is invalid #554

@mutianf

Description

@mutianf

To reproduce:

BigtableDataClient dataClient = BigtableDataClient.create(projectId, instanceId);
dataClient.bulkMutateRows(BulkMutation.create(tableId));

In this case the BulkMutation request is invalid, and it will cause MetricTracer to throw a java.lang.NullPointerException and hang the request.

SEVERE: RuntimeException while executing runnable com.google.api.gax.retrying.CallbackChainRetryingFuture$AttemptCompletionListener@19868320 with executor MoreExecutors.directExecutor()
java.lang.NullPointerException
	at com.google.cloud.bigtable.data.v2.stub.metrics.MetricsTracer.recordAttemptCompletion(MetricsTracer.java:167)
	at com.google.cloud.bigtable.data.v2.stub.metrics.MetricsTracer.attemptPermanentFailure(MetricsTracer.java:158)
	at com.google.cloud.bigtable.data.v2.stub.metrics.CompositeTracer.attemptPermanentFailure(CompositeTracer.java:116)

Metadata

Metadata

Assignees

Labels

api: bigtableIssues related to the googleapis/java-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions