ci: Add graalvm presubmit configs#3077
Conversation
diegomarquezp
left a comment
There was a problem hiding this comment.
LGTM, but a couple of questions I hope we can clarify in the description before continuing.
For the customNative vs native provided by shared-config, a separate issue makes sense to me since the change here is just moving the config inside the gapic bom.
| </includes> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> |
There was a problem hiding this comment.
qq:
https://github.com/googleapis/java-shared-config/blob/367086dc97b2eb91661ae48e46705368a0e64337/native-image-shared-config/pom.xml#L252
also declares a similar config for the native-maven-plugin. Do the customNative and native profiles cancel each other?
Also, did placing the customNative profile in the parent pom break the build?
There was a problem hiding this comment.
They're two separate profiles. For some reason BQStorage has non-default configs so it looks like it has a custom profile to use.
There was a problem hiding this comment.
Sounds good. I'll create a tracking issue to investigate this.
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>flatten-maven-plugin</artifactId> | ||
| </plugin> | ||
| <plugin> |
There was a problem hiding this comment.
qq: how did this plugin become unnecessary?
There was a problem hiding this comment.
java-shared-config defines it here: https://github.com/googleapis/java-shared-config/blob/367086dc97b2eb91661ae48e46705368a0e64337/java-shared-config/pom.xml#L596-L601
It is also activated by the EnableAutoValue.txt file which seems to generate it properly for JDK 24. I'm not entirely sure why it worked for JDK 11, 17, and 21, but not 24. Using the file method to activate it works.
Add the missing graalvm configs that is required for PRs
Requires the corresponding cl/797418719
There is a temp issue created to handle the workaround in owlbot: googleapis/google-cloud-java#11965