Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

feat: provide the default stream name#2444

Merged
yirutang merged 1 commit into
googleapis:mainfrom
tomrussello:get-default-name-from-stream-writer
Mar 13, 2024
Merged

feat: provide the default stream name#2444
yirutang merged 1 commit into
googleapis:mainfrom
tomrussello:get-default-name-from-stream-writer

Conversation

@tomrussello

@tomrussello tomrussello commented Mar 9, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2443 ☕️

@tomrussello tomrussello requested review from a team and Neenu1995 March 9, 2024 00:52
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Mar 9, 2024
@yirutang

yirutang commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

There are some lint error. please run:
mvn com.coveo:fmt-maven-plugin:format

@tomrussello tomrussello force-pushed the get-default-name-from-stream-writer branch from ee74230 to 4c08d91 Compare March 11, 2024 18:00
@tomrussello

tomrussello commented Mar 11, 2024

Copy link
Copy Markdown
Contributor Author

done @yirutang

@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2024
@yirutang yirutang added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 13, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 13, 2024
@yirutang yirutang merged commit fe9c3ae into googleapis:main Mar 13, 2024
@release-please release-please Bot mentioned this pull request Mar 13, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

1 more reviewer

@yirutang yirutang yirutang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StreamWriter should provide the default stream to a client

3 participants

@tomrussello @yirutang @yoshi-kokoro