Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

Multiplexing client: split writer into connection worker and wrapper#1774

Merged
yirutang merged 1 commit intogoogleapis:mainfrom
GaoleMeng:main
Sep 13, 2022
Merged

Multiplexing client: split writer into connection worker and wrapper#1774
yirutang merged 1 commit intogoogleapis:mainfrom
GaoleMeng:main

Conversation

@GaoleMeng
Copy link
Copy Markdown
Contributor

@GaoleMeng GaoleMeng commented Sep 9, 2022

BEGIN_COMMIT_OVERRIDE
feat: introducing connection worker to run a loop for fetching / sending requests in a queue.
END_COMMIT_OVERRIDE
This change is for the ongoing multiplexing client effort.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@GaoleMeng GaoleMeng requested review from a team and chalmerlowe September 9, 2022 03:39
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Sep 9, 2022
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf bot commented Sep 9, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Sep 9, 2022
@@ -0,0 +1,678 @@
/*
* Copyright 2020 Google LLC
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License year

@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2022
@GaoleMeng GaoleMeng requested a review from a team September 13, 2022 08:50
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2022
@yirutang yirutang merged commit 7dd447d into googleapis:main Sep 13, 2022
@Neenu1995 Neenu1995 added the release-please:force-run To run release-please label Sep 15, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants