Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

docs(samples): updated WriteComittedStream sample to align with expected use#1585

Closed
gnanda wants to merge 1 commit intogoogleapis:mainfrom
gnanda:update_samples
Closed

docs(samples): updated WriteComittedStream sample to align with expected use#1585
gnanda wants to merge 1 commit intogoogleapis:mainfrom
gnanda:update_samples

Conversation

@gnanda
Copy link
Copy Markdown
Contributor

@gnanda gnanda commented Mar 24, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples. labels Mar 24, 2022
@gnanda gnanda requested review from stephaniewang526 and yirutang and removed request for yirutang March 24, 2022 21:22
@gnanda gnanda requested a review from yirutang March 24, 2022 21:25
@stephaniewang526 stephaniewang526 changed the title Update WriteComittedStream sample to align with expected use docs(samples): updated WriteComittedStream sample to align with expected use Mar 28, 2022
yirutang
yirutang approved these changes Mar 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine moving forward with this since it is already better than the original sample. Let's add in the rest, maybe on default streams later.

@VeronicaWasson VeronicaWasson mentioned this pull request Apr 1, 2022
Merged
4 tasks
@gnanda gnanda closed this Apr 22, 2022
@gnanda gnanda deleted the update_samples branch April 22, 2022 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526

1 more reviewer

@yirutang yirutang yirutang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gnanda @yirutang