This repository was archived by the owner on Feb 24, 2026. It is now read-only.
fix: add client id and update trace id population for StreamWriter and JsonWriter#2389
Merged
Conversation
GaoleMeng
reviewed
Feb 6, 2024
|
|
||
| private String traceId = null; | ||
|
|
||
| private String clientId = "java-streamwriter"; |
| private Builder(SchemaAwareStreamWriter.Builder<Object> schemaAwareStreamWriterBuilder) { | ||
| this.schemaAwareStreamWriterBuilder = | ||
| schemaAwareStreamWriterBuilder.setTraceIdBase("JsonWriter"); | ||
| schemaAwareStreamWriterBuilder.setClientId("java-jsonwriter"); |
Contributor
Author
There was a problem hiding this comment.
Do you mean this? In theory this can be set too but we just don't bother exposing it.
GaoleMeng
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.