feat: bug fix for checking write_stream field but proto might not contain the field to unblock the release (#1806)

GaoleMeng · gcf-owl-bot[bot] · web-flow · commit 9791d693c753 · 2022-09-29T13:17:01.000-07:00
* feat: Split writer into connection worker and wrapper, this is a prerequisite for multiplexing client * feat: add connection worker pool skeleton, used for multiplexing client * feat: add Load api for connection worker for multiplexing client * feat: add multiplexing support to connection worker. We will treat every new stream name as a switch of destinationt * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: port the multiplexing client core algorithm and basic tests also fixed a tiny bug inside fake bigquery write impl for getting thre response from offset * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: wire multiplexing connection pool to stream writer * feat: some fixes for multiplexing client * feat: fix some todos, and reject the mixed behavior of passed in client or not * feat: fix the bug that we may peek into the write_stream field but it's possible the proto schema does not contain this field * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
diff --git a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java
@@ -586,13 +586,18 @@ private void cleanupInflightRequests() {
   }
 
   private void requestCallback(AppendRowsResponse response) {
-    log.fine(
-        "Got response on stream '"
-            + response.getWriteStream()
-            + "' "
-            + (response.hasError()
-                ? "error: " + response.getError()
-                : "offset: " + response.getAppendResult().getOffset().getValue()));
+    if (!response.hasUpdatedSchema()) {
+      log.fine(String.format("Got response on stream %s", response.toString()));
+    } else {
+      AppendRowsResponse responseWithUpdatedSchemaRemoved =
+          response.toBuilder().clearUpdatedSchema().build();
+
+      log.fine(
+          String.format(
+              "Got response with schema updated (omitting updated schema in response here): %s",
+              responseWithUpdatedSchemaRemoved.toString()));
+    }
+
     AppendRequestAndResponse requestWrapper;
     this.lock.lock();
     if (response.hasUpdatedSchema()) {
