Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

Commit 523afa4

Browse files
stephaniewang526stephaniewang526
committed
chore: clean up clirr-ignored-differences.xml in various proto modules
add permanent blanket exception for protobuf generated OrBuilder interface methods as we don't consider these breaking.
1 parent 58d2101 commit 523afa4

File tree

6 files changed

+27
-242
lines changed

6 files changed

+27
-242
lines changed

‎google-cloud-bigquerystorage/clirr-ignored-differences.xml‎

Lines changed: 0 additions & 51 deletions
This file was deleted.

‎grpc-google-cloud-bigquerystorage-v1beta1/clirr-ignored-differences.xml‎

Lines changed: 0 additions & 9 deletions
This file was deleted.

‎proto-google-cloud-bigquerystorage-v1/clirr-ignored-differences.xml‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
3+
<differences>
4+
<!-- Allow below protobuf changes as non-breaking-->
5+
<difference>
6+
<differenceType>7012</differenceType>
7+
<className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className>
8+
<method>* get*(*)</method>
9+
</difference>
10+
<difference>
11+
<differenceType>7012</differenceType>
12+
<className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className>
13+
<method>boolean contains*(*)</method>
14+
</difference>
15+
<difference>
16+
<differenceType>7012</differenceType>
17+
<className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className>
18+
<method>boolean has*(*)</method>
19+
</difference>
20+
</differences>

‎proto-google-cloud-bigquerystorage-v1alpha2/clirr-ignored-differences.xml‎

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎proto-google-cloud-bigquerystorage-v1beta1/clirr-ignored-differences.xml‎

Lines changed: 0 additions & 9 deletions
This file was deleted.

‎proto-google-cloud-bigquerystorage-v1beta2/clirr-ignored-differences.xml‎

Lines changed: 7 additions & 163 deletions
Original file line numberDiff line numberDiff line change
@@ -1,176 +1,20 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
33
<differences>
4-
<!-- TODO(stephwang): To be removed after the release -->
5-
6-
<!-- CONSTANT FIELDS REMOVED -->
4+
<!-- Allow below protobuf changes as non-breaking-->
75
<difference>
8-
<differenceType>6011</differenceType>
9-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest</className>
10-
<field>IGNORE_UNKNOWN_FIELDS_FIELD_NUMBER</field>
11-
</difference>
12-
<difference>
13-
<differenceType>6011</differenceType>
14-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse</className>
15-
<field>OFFSET_FIELD_NUMBER</field>
16-
</difference>
17-
<difference>
18-
<differenceType>6011</differenceType>
19-
<className>com/google/cloud/bigquery/storage/v1beta2/WriteStream</className>
20-
<field>EXTERNAL_ID_FIELD_NUMBER</field>
21-
</difference>
22-
23-
<!-- METHODS REMOVED -->
24-
<difference>
25-
<differenceType>7002</differenceType>
26-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest</className>
27-
<method>boolean getIgnoreUnknownFields()</method>
28-
</difference>
29-
<difference>
30-
<differenceType>7002</differenceType>
31-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest$Builder</className>
32-
<method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest$Builder clearIgnoreUnknownFields()</method>
33-
</difference>
34-
<difference>
35-
<differenceType>7002</differenceType>
36-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest*</className>
37-
<method>boolean getIgnoreUnknownFields()</method>
38-
</difference>
39-
<difference>
40-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest$Builder</className>
41-
<differenceType>7002</differenceType>
42-
<method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest$Builder setIgnoreUnknownFields(boolean)</method>
43-
</difference>
44-
<difference>
45-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest$Builder</className>
46-
<differenceType>7002</differenceType>
47-
<method>boolean getIgnoreUnknownFields()</method>
48-
</difference>
49-
<difference>
50-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse</className>
51-
<differenceType>7002</differenceType>
52-
<method>long getOffset()</method>
53-
</difference>
54-
<difference>
55-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse$Builder</className>
56-
<differenceType>7002</differenceType>
57-
<method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$Builder clearOffset()</method>
58-
</difference>
59-
<difference>
60-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse$Builder</className>
61-
<differenceType>7002</differenceType>
62-
<method>long getOffset()</method>
63-
</difference>
64-
<difference>
65-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse$Builder</className>
66-
<differenceType>7002</differenceType>
67-
<method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$Builder setOffset(long)</method>
68-
</difference>
69-
<difference>
70-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse$ResponseCase</className>
71-
<differenceType>6001</differenceType>
72-
<field>OFFSET</field>
73-
</difference>
74-
<difference>
75-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponseOrBuilder</className>
76-
<differenceType>7002</differenceType>
77-
<method>long getOffset()</method>
78-
</difference>
79-
<difference>
80-
<className>com/google/cloud/bigquery/storage/v1beta2/WriteStream</className>
81-
<differenceType>7002</differenceType>
82-
<method>java.lang.String getExternalId()</method>
83-
</difference>
84-
<difference>
85-
<className>com/google/cloud/bigquery/storage/v1beta2/WriteStream</className>
86-
<differenceType>7002</differenceType>
87-
<method>com.google.protobuf.ByteString getExternalIdBytes()</method>
88-
</difference>
89-
<difference>
90-
<className>com/google/cloud/bigquery/storage/v1beta2/WriteStream$Builder</className>
91-
<differenceType>7002</differenceType>
92-
<method>com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder clearExternalId()</method>
93-
</difference>
94-
<difference>
95-
<className>com/google/cloud/bigquery/storage/v1beta2/WriteStream$Builder</className>
96-
<differenceType>7002</differenceType>
97-
<method>java.lang.String getExternalId()</method>
98-
</difference>
99-
<difference>
100-
<className>com/google/cloud/bigquery/storage/v1beta2/WriteStream$Builder</className>
101-
<differenceType>7002</differenceType>
102-
<method>com.google.protobuf.ByteString getExternalIdBytes()</method>
103-
</difference>
104-
<difference>
105-
<className>com/google/cloud/bigquery/storage/v1beta2/WriteStream$Builder</className>
106-
<differenceType>7002</differenceType>
107-
<method>com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder setExternalId(java.lang.String)</method>
108-
</difference>
109-
<difference>
110-
<className>com/google/cloud/bigquery/storage/v1beta2/WriteStream$Builder</className>
111-
<differenceType>7002</differenceType>
112-
<method>com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder setExternalIdBytes(com.google.protobuf.ByteString)</method>
113-
</difference>
114-
<difference>
115-
<className>com/google/cloud/bigquery/storage/v1beta2/WriteStreamOrBuilder</className>
116-
<differenceType>7002</differenceType>
117-
<method>java.lang.String getExternalId()</method>
118-
</difference>
119-
<difference>
120-
<className>com/google/cloud/bigquery/storage/v1beta2/WriteStreamOrBuilder</className>
121-
<differenceType>7002</differenceType>
122-
<method>com.google.protobuf.ByteString getExternalIdBytes()</method>
123-
</difference>
124-
125-
<!-- METHODS ADDED -->
126-
<difference>
127-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequestOrBuilder</className>
128-
<differenceType>7012</differenceType>
129-
<method>java.lang.String getTraceId()</method>
130-
</difference>
131-
<difference>
132-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequestOrBuilder</className>
133-
<differenceType>7012</differenceType>
134-
<method>com.google.protobuf.ByteString getTraceIdBytes()</method>
135-
</difference>
136-
<difference>
137-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponseOrBuilder</className>
138-
<differenceType>7012</differenceType>
139-
<method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$AppendResult getAppendResult()</method>
140-
</difference>
141-
<difference>
142-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponseOrBuilder</className>
143-
<differenceType>7012</differenceType>
144-
<method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$AppendResultOrBuilder getAppendResultOrBuilder()</method>
145-
</difference>
146-
<difference>
147-
<className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponseOrBuilder</className>
148-
<differenceType>7012</differenceType>
149-
<method>boolean hasAppendResult()</method>
150-
</difference>
151-
<difference>
152-
<className>com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder</className>
153-
<differenceType>7012</differenceType>
154-
<method>com.google.cloud.bigquery.storage.v1beta2.StorageError getStreamErrors(int)</method>
155-
</difference>
156-
<difference>
157-
<className>com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder</className>
158-
<differenceType>7012</differenceType>
159-
<method>int getStreamErrorsCount()</method>
160-
</difference>
161-
<difference>
162-
<className>com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder</className>
1636
<differenceType>7012</differenceType>
164-
<method>java.util.List getStreamErrorsList()</method>
7+
<className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className>
8+
<method>* get*(*)</method>
1659
</difference>
16610
<difference>
167-
<className>com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder</className>
16811
<differenceType>7012</differenceType>
169-
<method>com.google.cloud.bigquery.storage.v1beta2.StorageErrorOrBuilder getStreamErrorsOrBuilder(int)</method>
12+
<className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className>
13+
<method>boolean contains*(*)</method>
17014
</difference>
17115
<difference>
172-
<className>com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder</className>
17316
<differenceType>7012</differenceType>
174-
<method>java.util.List getStreamErrorsOrBuilderList()</method>
17+
<className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className>
18+
<method>boolean has*(*)</method>
17519
</difference>
17620
</differences>

0 commit comments

Comments
 (0)