.

yirutang · yirutang · commit 4610ea9ac92b · 2021-05-04T13:15:27.000-07:00
diff --git a/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/it/ITBigQueryWriteManualClientTest.java b/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/it/ITBigQueryWriteManualClientTest.java
@@ -447,133 +447,6 @@ public void testJsonStreamWriterWithDefaultStream()
     }
   }
 
-  @Test
-  public void testJsonStreamWriterSchemaUpdate()
-      throws IOException, InterruptedException, ExecutionException,
-          Descriptors.DescriptorValidationException {
-    String tableName = "SchemaUpdateTable";
-    TableInfo tableInfo =
-        TableInfo.newBuilder(
-                TableId.of(DATASET, tableName),
-                StandardTableDefinition.of(
-                    Schema.of(
-                        com.google.cloud.bigquery.Field.newBuilder("foo", LegacySQLTypeName.STRING)
-                            .build())))
-            .build();
-
-    // Create a Bigquery table.
-    bigquery.create(tableInfo);
-    TableName parent = TableName.of(ServiceOptions.getDefaultProjectId(), DATASET, tableName);
-    // Create a Write Api stream.
-    WriteStream writeStream =
-        client.createWriteStream(
-            CreateWriteStreamRequest.newBuilder()
-                .setParent(parent.toString())
-                .setWriteStream(
-                    WriteStream.newBuilder().setType(WriteStream.Type.COMMITTED).build())
-                .build());
-
-    try (JsonStreamWriter jsonStreamWriter =
-        JsonStreamWriter.newBuilder(writeStream.getName(), writeStream.getTableSchema()).build()) {
-      // 1). Send 1 row
-      JSONObject foo = new JSONObject();
-      foo.put("foo", "aaa");
-      JSONArray jsonArr = new JSONArray();
-      jsonArr.put(foo);
-
-      ApiFuture<AppendRowsResponse> response = jsonStreamWriter.append(jsonArr, 0);
-      assertEquals(0, response.get().getAppendResult().getOffset().getValue());
-      // 2). Schema update and wait until querying it returns a new schema.
-      try {
-        com.google.cloud.bigquery.Table table = bigquery.getTable(DATASET, tableName);
-        Schema schema = table.getDefinition().getSchema();
-        FieldList fields = schema.getFields();
-        Field newField =
-            Field.newBuilder("bar", LegacySQLTypeName.STRING).setMode(Field.Mode.NULLABLE).build();
-
-        List<Field> fieldList = new ArrayList<Field>();
-        fieldList.add(fields.get(0));
-        fieldList.add(newField);
-        Schema newSchema = Schema.of(fieldList);
-        // Update the table with the new schema
-        com.google.cloud.bigquery.Table updatedTable =
-            table.toBuilder().setDefinition(StandardTableDefinition.of(newSchema)).build();
-        updatedTable.update();
-        int millis = 0;
-        while (millis <= 10000) {
-          if (newSchema.equals(table.reload().getDefinition().getSchema())) {
-            break;
-          }
-          Thread.sleep(1000);
-          millis += 1000;
-        }
-        newSchema = schema;
-        LOG.info(
-            "bar column successfully added to table in "
-                + millis
-                + " millis: "
-                + bigquery.getTable(DATASET, tableName).getDefinition().getSchema());
-      } catch (BigQueryException e) {
-        LOG.severe("bar column was not added. \n" + e.toString());
-      }
-      // 3). Send rows to wait for updatedSchema to be returned.
-      JSONObject foo2 = new JSONObject();
-      foo2.put("foo", "bbb");
-      JSONArray jsonArr2 = new JSONArray();
-      jsonArr2.put(foo2);
-
-      int next = 0;
-      for (int i = 1; i < 100; i++) {
-        ApiFuture<AppendRowsResponse> response2 = jsonStreamWriter.append(jsonArr2, i);
-        assertEquals(i, response2.get().getAppendResult().getOffset().getValue());
-        if (response2.get().hasUpdatedSchema()) {
-          next = i;
-          break;
-        } else {
-          Thread.sleep(1000);
-        }
-      }
-
-      int millis = 0;
-      while (millis <= 10000) {
-        if (jsonStreamWriter.getDescriptor().getFields().size() == 2) {
-          LOG.info("JsonStreamWriter successfully updated internal descriptor!");
-          break;
-        }
-        Thread.sleep(100);
-        millis += 100;
-      }
-      assertTrue(jsonStreamWriter.getDescriptor().getFields().size() == 2);
-      // 4). Send rows with updated schema.
-      JSONObject updatedFoo = new JSONObject();
-      updatedFoo.put("foo", "ccc");
-      updatedFoo.put("bar", "ddd");
-      JSONArray updatedJsonArr = new JSONArray();
-      updatedJsonArr.put(updatedFoo);
-      for (int i = 0; i < 10; i++) {
-        ApiFuture<AppendRowsResponse> response3 =
-            jsonStreamWriter.append(updatedJsonArr, next + 1 + i);
-        assertEquals(next + 1 + i, response3.get().getAppendResult().getOffset().getValue());
-        response3.get();
-      }
-
-      TableResult result3 =
-          bigquery.listTableData(
-              tableInfo.getTableId(), BigQuery.TableDataListOption.startIndex(0L));
-      Iterator<FieldValueList> iter3 = result3.getValues().iterator();
-      assertEquals("aaa", iter3.next().get(0).getStringValue());
-      for (int j = 1; j <= next; j++) {
-        assertEquals("bbb", iter3.next().get(0).getStringValue());
-      }
-      for (int j = next + 1; j < next + 1 + 10; j++) {
-        FieldValueList temp = iter3.next();
-        assertEquals("ccc", temp.get(0).getStringValue());
-        assertEquals("ddd", temp.get(1).getStringValue());
-      }
-      assertEquals(false, iter3.hasNext());
-    }
-  }
-
   @Test
   public void testComplicateSchemaWithPendingStream()
       throws IOException, InterruptedException, ExecutionException {
