Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

refactor: remove duplicate page token field from listdatasets#868

Merged
stephaniewang526 merged 1 commit intogoogleapis:masterfrom
pmakani:cleanp-pagetoken
Oct 26, 2020
Merged

refactor: remove duplicate page token field from listdatasets#868
stephaniewang526 merged 1 commit intogoogleapis:masterfrom
pmakani:cleanp-pagetoken

Conversation

@pmakani
Copy link
Copy Markdown
Contributor

@pmakani pmakani commented Oct 26, 2020

Fixes #867

@pmakani pmakani requested review from a team and stephaniewang526 October 26, 2020 07:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 26, 2020

Codecov Report

Merging #868 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #868      +/-   ##
============================================
+ Coverage     80.37%   80.38%   +0.01%     
  Complexity     1268     1268              
============================================
  Files            79       79              
  Lines          6548     6547       -1     
  Branches        750      750              
============================================
  Hits           5263     5263              
+ Misses          892      891       -1     
  Partials        393      393              
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 4.41% <ø> (+0.01%) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b9e92...a9b67cb. Read the comment docs.

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Oct 26, 2020
@stephaniewang526 stephaniewang526 merged commit d1d72ed into googleapis:master Oct 26, 2020
@pmakani pmakani deleted the cleanp-pagetoken branch October 27, 2020 06:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup: duplicate code for page token in listdatasets

2 participants