Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

refactor(samples): add logs and remove redundant code#716

Merged
stephaniewang526 merged 2 commits intogoogleapis:masterfrom
pmakani:record-logs
Sep 2, 2020
Merged

refactor(samples): add logs and remove redundant code#716
stephaniewang526 merged 2 commits intogoogleapis:masterfrom
pmakani:record-logs

Conversation

@pmakani
Copy link
Copy Markdown
Contributor

@pmakani pmakani commented Sep 1, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2020 •
edited
Loading

Codecov Report

Merging #716 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #716   +/-   ##
=========================================
  Coverage     81.06%   81.06%           
  Complexity     1236     1236           
=========================================
  Files            78       78           
  Lines          6332     6332           
  Branches        704      704           
=========================================
  Hits           5133     5133           
  Misses          833      833           
  Partials        366      366

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be6a2b...a172bf2. Read the comment docs.

@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2020
@pmakani pmakani marked this pull request as ready for review September 2, 2020 06:55
@pmakani pmakani requested a review from a team September 2, 2020 06:55
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Sep 2, 2020
@stephaniewang526 stephaniewang526 merged commit 70417fc into googleapis:master Sep 2, 2020
@pmakani pmakani deleted the record-logs branch September 2, 2020 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmakani @stephaniewang526 @yoshi-kokoro