Skip to content

chore: fix named query parameter struct tests #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 3 commits into from
Feb 1, 2023
Merged

chore: fix named query parameter struct tests #2504

gcf-merge-on-green merged 3 commits into from
Feb 1, 2023

Conversation

@Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Feb 1, 2023 •
edited
Loading

Fixes #2485
Fixes #2496
Fixes #2498
Fixes #2497

@Neenu1995 Neenu1995 requested review from a team and rosiezou February 1, 2023 18:49
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Feb 1, 2023
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2023
@Neenu1995 Neenu1995 requested a review from a team as a code owner February 1, 2023 20:20
@generated-files-bot
Copy link

generated-files-bot bot commented Feb 1, 2023

Warning: This pull request is touching the following templated files:

  • .kokoro/build.sh

@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
alvarowolfx
alvarowolfx approved these changes Feb 1, 2023
View reviewed changes
Copy link

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 1, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6b7c0a9 into main Feb 1, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-struct-test branch February 1, 2023 20:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvarowolfx alvarowolfx alvarowolfx approved these changes

@rosiezou rosiezou Awaiting requested review from rosiezou

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

3 participants

@Neenu1995 @alvarowolfx @yoshi-kokoro