This repository was archived by the owner on Mar 23, 2026. It is now read-only.
fix: Add query dryRun logic to get the schema when null schema is returned from the backend#2106
Merged
prash-mi merged 6 commits intogoogleapis:mainfrom Jul 20, 2022
Conversation
…a for the Fast query path
…obal to reduce code duplicity
Contributor
Author
|
blocked on b/235591056 |
This was referenced Jun 10, 2022
Contributor
Author
|
@gnanda The failing integration tests are now passing, can you please have a look and let me know |
…into fix-npe-test-iterate-and-order # Conflicts: # README.md
shollyman
approved these changes
Jul 19, 2022
Contributor
shollyman
left a comment
There was a problem hiding this comment.
Per discussion, add instrumentation to disambiguate non-complete and missing schema cases.
Contributor
Author
|
@shollyman Thanks Seth. I have added the additional logs. |
This was referenced Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added dryRun Logic in query RPC when the backend returns a
nullschema for the Fast query pathAdded unit test case and minor refactor
Fixes #2103 #2114 and #2113 ☕️