Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

test: add integration test for Column ACLs#1266

Merged
gcf-merge-on-green[bot] merged 7 commits intogoogleapis:masterfrom
stephaniewang526:add-it-column-acl
Apr 30, 2021
Merged

test: add integration test for Column ACLs#1266
gcf-merge-on-green[bot] merged 7 commits intogoogleapis:masterfrom
stephaniewang526:add-it-column-acl

Conversation

@stephaniewang526
Copy link
Copy Markdown
Contributor

Fixes: #1244

@stephaniewang526 stephaniewang526 requested review from a team and shollyman April 29, 2021 23:47
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Apr 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2021
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/dependencies.sh

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1266 (70ea98a) into master (45f4a39) will not change coverage.
The diff coverage is n/a.

❗ Current head 70ea98a differs from pull request most recent head 1ce6dd0. Consider uploading reports for the commit 1ce6dd0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1266   +/-   ##
=========================================
  Coverage     80.19%   80.19%           
  Complexity     1271     1271           
=========================================
  Files            79       79           
  Lines          6639     6639           
  Branches        767      767           
=========================================
  Hits           5324     5324           
  Misses          917      917           
  Partials        398      398           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f4a39...1ce6dd0. Read the comment docs.

Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. Not sure I understand the changes in dependencies.sh, but you're far more familiar with java dependency management than I am.

@stephaniewang526
Copy link
Copy Markdown
Contributor Author

Thanks for putting this together. Not sure I understand the changes in dependencies.sh, but you're far more familiar with java dependency management than I am.

Thanks! Yes, I reported this known issue with maven-dependency-plugin on 03/01/2021 and haven't heard anything back yet. Therefore, adding the exclusion as a temporary fix. I added this issue in the comment in case it gets fixed so we can remove it.

@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit fc3059e into googleapis:master Apr 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minor: integration test for column ACLs feature

2 participants