Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

chore(ci): xml namespace declaration in samples/snippets/pom.xml#1199

Merged
stephaniewang526 merged 2 commits intogoogleapis:masterfrom
suztomo:xml_declaration
Mar 25, 2021
Merged

chore(ci): xml namespace declaration in samples/snippets/pom.xml#1199
stephaniewang526 merged 2 commits intogoogleapis:masterfrom
suztomo:xml_declaration

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Mar 25, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1200 ☕️

@suztomo suztomo requested review from a team and shollyman March 25, 2021 16:07
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Mar 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 25, 2021
@suztomo suztomo changed the title xml namespace declaration in samples/snippets/pom.xml chore: xml namespace declaration in samples/snippets/pom.xml Mar 25, 2021
@suztomo suztomo changed the title chore: xml namespace declaration in samples/snippets/pom.xml chore(ci): xml namespace declaration in samples/snippets/pom.xml Mar 25, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2021

Codecov Report

Merging #1199 (62913d0) into master (9b9d378) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1199   +/-   ##
=========================================
  Coverage     80.17%   80.17%           
  Complexity     1270     1270           
=========================================
  Files            79       79           
  Lines          6629     6629           
  Branches        766      767    +1     
=========================================
  Hits           5315     5315           
  Misses          916      916           
  Partials        398      398           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9d378...62913d0. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit a62ee9f into googleapis:master Mar 25, 2021
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Mar 25, 2021

The bot says samples/snippets/pom.xml is from template. Checking further.

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Mar 25, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

samples/snippets/pom.xml is not declaring namespace

4 participants