Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

samples: Fixes #1051#1053

Merged
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:masterfrom
dineshraj01:bigquery_view_update_fix
Jan 11, 2021
Merged

samples: Fixes #1051#1053
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:masterfrom
dineshraj01:bigquery_view_update_fix

Conversation

@dineshraj01
Copy link
Copy Markdown
Contributor

Passed updated view definition to bigquery.update() method.

Fixes #1051 ☕️

Passed updated view definition to bigquery.update() method.
@dineshraj01 dineshraj01 requested a review from a team January 8, 2021 11:04
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Jan 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 8, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 8, 2021

Codecov Report

Merging #1053 (ca94625) into master (36404f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1053   +/-   ##
=========================================
  Coverage     80.18%   80.18%           
  Complexity     1268     1268           
=========================================
  Files            79       79           
  Lines          6576     6576           
  Branches        760      761    +1     
=========================================
  Hits           5273     5273           
  Misses          910      910           
  Partials        393      393           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36404f2...ca94625. Read the comment docs.

@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jan 11, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 66f3168 into googleapis:master Jan 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 11, 2021
@dineshraj01
Copy link
Copy Markdown
Contributor Author

@stephaniewang526 I checked the documentation at https://cloud.google.com/bigquery/docs/updating-views#update-sql and it shows code snippet prior to this commit. Do I need to update documentation separately?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample UpdateViewQuery.java does not work.

5 participants