Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

chore: add env var for changing cloud-samples-data bucket#1021

Merged
stephaniewang526 merged 3 commits intogoogleapis:masterfrom
bmccutchon:master
Dec 15, 2020
Merged

chore: add env var for changing cloud-samples-data bucket#1021
stephaniewang526 merged 3 commits intogoogleapis:masterfrom
bmccutchon:master

Conversation

@bmccutchon
Copy link
Copy Markdown
Contributor

@bmccutchon bmccutchon commented Dec 14, 2020

This makes it possible to run the tests in a VPC Service Controls perimeter where public buckets may be unreachable.

@bmccutchon bmccutchon requested review from a team and pmakani December 14, 2020 21:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 14, 2020
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Dec 14, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 14, 2020 •
edited
Loading

Codecov Report

Merging #1021 (4f4049a) into master (b62e8f2) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1021      +/-   ##
============================================
- Coverage     80.18%   80.14%   -0.05%     
+ Complexity     1268     1267       -1     
============================================
  Files            79       79              
  Lines          6576     6556      -20     
  Branches        760      739      -21     
============================================
- Hits           5273     5254      -19     
+ Misses          910      909       -1     
  Partials        393      393
Impacted Files Coverage Δ Complexity Δ
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0.00%> (-1.32%) 7.00% <0.00%> (ø%)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0.00%> (-1.10%) 5.00% <0.00%> (ø%)
...gle/cloud/bigquery/MaterializedViewDefinition.java 70.00% <0.00%> (-0.97%) 6.00% <0.00%> (ø%)
...ava/com/google/cloud/bigquery/RoutineArgument.java 90.47% <0.00%> (-0.44%) 5.00% <0.00%> (ø%)
...va/com/google/cloud/bigquery/StandardSQLField.java 90.47% <0.00%> (-0.44%) 7.00% <0.00%> (ø%)
...java/com/google/cloud/bigquery/ViewDefinition.java 87.09% <0.00%> (-0.41%) 11.00% <0.00%> (ø%)
...google/cloud/bigquery/ExternalTableDefinition.java 58.18% <0.00%> (-0.38%) 21.00% <0.00%> (ø%)
...y/src/main/java/com/google/cloud/bigquery/Job.java 84.45% <0.00%> (-0.21%) 33.00% <0.00%> (-1.00%)
...om/google/cloud/bigquery/BigtableColumnFamily.java 95.83% <0.00%> (-0.17%) 5.00% <0.00%> (ø%)
...google/cloud/bigquery/StandardTableDefinition.java 93.24% <0.00%> (-0.10%) 16.00% <0.00%> (ø%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62e8f2...16bf72b. Read the comment docs.

@bmccutchon @yoshi-code-bot
Change line breaking per suggestion
4f4049a 
Co-authored-by: yoshi-code-bot <70984784+yoshi-code-bot@users.noreply.github.com>
@stephaniewang526 stephaniewang526 changed the title Add env var for changing cloud-samples-data bucket chore: add env var for changing cloud-samples-data bucket Dec 15, 2020
@stephaniewang526
Copy link
Copy Markdown
Contributor

stephaniewang526 commented Dec 15, 2020

@kurtisvg @lesv Do you have any objections to this change please?

@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 15, 2020
@stephaniewang526
Copy link
Copy Markdown
Contributor

stephaniewang526 commented Dec 15, 2020

@bmccutchon can you take a look at the compilation errors?

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project google-cloud-bigquery: Compilation failure: Compilation failure: 
Error:  /home/runner/work/java-bigquery/java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java:[124,17] cannot find symbol
Error:    symbol:   class Optional
Error:    location: package java.util
Error:  /home/runner/work/java-bigquery/java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java:[124,17] cannot find symbol
Error:    symbol:   class Optional
Error:    location: package java.util
Error:  /home/runner/work/java-bigquery/java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java:[153,7] cannot find symbol
Error:    symbol:   variable Optional
Error:    location: class com.google.cloud.bigquery.it.ITBigQueryTest
Error:  -> [Help 1]

full stacktrace

@stephaniewang526 stephaniewang526 removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 15, 2020
@bmccutchon
Use Guava Optional instead of Java 8 Optional
16bf72b 
This allows the tests to compile and run under Java 7.
@bmccutchon
Copy link
Copy Markdown
Contributor Author

bmccutchon commented Dec 15, 2020

I replaced java.util.Optional with com.google.common.base.Optional. I think that should fix it. Please take another look.

@stephaniewang526 stephaniewang526 merged commit 46708f7 into googleapis:master Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pmakani pmakani Awaiting requested review from pmakani

@lesv lesv Awaiting requested review from lesv

3 more reviewers

@yoshi-code-bot yoshi-code-bot yoshi-code-bot left review comments

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

@kolea2 kolea2

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bmccutchon @stephaniewang526 @kurtisvg @yoshi-code-bot @averikitsch @kolea2