Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

samples: add quickstart sample and integration tests#281

Merged
chingor13 merged 3 commits intomasterfrom
it
Dec 11, 2020
Merged

samples: add quickstart sample and integration tests#281
chingor13 merged 3 commits intomasterfrom
it

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Dec 9, 2020 •
edited
Loading

Adding a smoke test (and a quickstart snippet while we're at it).

@chingor13 chingor13 requested review from a team December 9, 2020 22:53
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot bot commented Dec 9, 2020

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2020
@product-auto-label product-auto-label bot added api: accessapproval Issues related to the googleapis/java-accessapproval API. samples Issues that are directly related to samples. labels Dec 9, 2020
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Dec 9, 2020 •
edited
Loading

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@chingor13 chingor13 requested a review from Neenu1995 December 9, 2020 22:53
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #281 (7a9cf5a) into master (478e905) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #281   +/-   ##
=========================================
  Coverage     77.91%   77.91%           
  Complexity       64       64           
=========================================
  Files             6        6           
  Lines           471      471           
  Branches          2        2           
=========================================
  Hits            367      367           
  Misses          102      102           
  Partials          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478e905...7a9cf5a. Read the comment docs.

@generated-files-bot
Copy link
Copy Markdown

generated-files-bot bot commented Dec 9, 2020

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@generated-files-bot
Copy link
Copy Markdown

generated-files-bot bot commented Dec 9, 2020

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@chingor13
Copy link
Copy Markdown
Contributor Author

chingor13 commented Dec 9, 2020

cc @jskeet Access Approval seems to correctly return an empty list for Java.

@jskeet
Copy link
Copy Markdown

jskeet commented Dec 10, 2020

@chingor13: Thanks. Will file an issue to get to the bottom of what's going on in .NET.

@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 11, 2020
@chingor13 chingor13 merged commit a054c96 into master Dec 11, 2020
@chingor13 chingor13 deleted the it branch December 11, 2020 22:07
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@yoshi-code-bot yoshi-code-bot yoshi-code-bot left review comments

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

@shubha-rajan shubha-rajan

Labels

api: accessapproval Issues related to the googleapis/java-accessapproval API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@chingor13 @jskeet @BenWhitehead @Neenu1995 @kurtisvg @yoshi-code-bot @averikitsch @shubha-rajan