This repository was archived by the owner on Sep 18, 2023. It is now read-only.
Conversation
feat: added flag for implicit dismissal for `DismissDecision` PiperOrigin-RevId: 427766265 Source-Link: googleapis/googleapis@5556c91 Source-Link: https://github.com/googleapis/googleapis-gen/commit/d03fa03b217462784d6ba32ccdde4dfe0c06f017 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDAzZmEwM2IyMTc0NjI3ODRkNmJhMzJjY2RkZTRkZmUwYzA2ZjAxNyJ9
chanseokoh
approved these changes
Feb 11, 2022
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
stephaniewang526
approved these changes
Feb 23, 2022
lesv
reviewed
Feb 23, 2022
Comment on lines
+425
to
+426
| ApprovalRequestName.ofProjectApprovalRequestName("[PROJECT]", "[APPROVAL_REQUEST]") | ||
| .toString()) |
There was a problem hiding this comment.
These things are really what you want in your tests? May be ok for mocks, but probably not for IT tests.
lesv
approved these changes
Feb 23, 2022
|
@lesv @stephaniewang526 Any idea if these errors are legitimate or if they're transient? The Access Approval Engineer was eager to get the documentation updates propagated to all the languages. |
Java 8Either something is missing or something was added that shouldn't be. Either way, something needs to be fixed - it's not a transient failure. Does it compile on the engineers desktop? Looking at the lint execution, the only weird thing I see is: Lint |
Contributor
|
Broken build was due to missing dependencies. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 24, 2022
🤖 I have created a release *beep* *boop* --- ### [2.1.11](v2.1.10...v2.1.11) (2022-02-24) ### Documentation * added resource annotations ([#670](#670)) ([8b0b14f](8b0b14f)) ### Dependencies * update actions/github-script action to v6 ([#672](#672)) ([cbbaf6c](cbbaf6c)) * update dependency com.google.cloud:google-cloud-core to v2.5.0 ([#664](#664)) ([4e7d615](4e7d615)) * update dependency com.google.cloud:google-cloud-core to v2.5.4 ([#678](#678)) ([fcf3ff0](fcf3ff0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: added flag for implicit dismissal for
DismissDecisionPiperOrigin-RevId: 427766265
Source-Link: googleapis/googleapis@5556c91
Source-Link: https://github.com/googleapis/googleapis-gen/commit/d03fa03b217462784d6ba32ccdde4dfe0c06f017
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDAzZmEwM2IyMTc0NjI3ODRkNmJhMzJjY2RkZTRkZmUwYzA2ZjAxNyJ9