feat(bazel): make googleapis a Bzlmod module#892
Conversation
| switched_rules.use_languages( | ||
| cc = True, | ||
| # csharp = True, | ||
| # gapic = True, |
There was a problem hiding this comment.
i left some of these out, which means not everything in the repo builds with bzlmod enabled, in order to support each of these we'll have to move their deps to bzlmod, which is potentially difficult depending on their transitives
|
|
||
| load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
|
|
||
| _disco_to_proto3_converter_version = "74c0ede1e6871c878de6c3cab3ef152280c6518f" |
There was a problem hiding this comment.
they aren't. i didn't handle all the different language specific dependencies here, and this one is one that was easy enough to throw here so that a few more targets built when testing the integration in this repo.
|
the dependency is merged so this is reviewable now! |
|
@meteorcloudy could you help route this? |
|
I'll ask around |
|
Thank you for this. Saved me a ton of time instead of trying to figure out how to port switched_rules over. I feel like that should be documented some place although it's not documented for use in WORKSPACE as well so not really regressing at all here. |
|
yea i think if this gets merged we can improve these things. this is already included in the BCR and there are a few examples in there like grpc-java using this extension |
|
@Wyverald will follow this up with the internal teams. We should really improve the protobuf + grpc + googleapis situation. |
|
@meteorcloudy any updates? |
|
Hello -- I'm still in talks with the team internally at Google. There's a concurrent proposal to reshape the project structure or something, and they're apparently exploring other options of exposing the protos to downstream users. |
|
@Wyverald Any news on this? |
|
+1 |
|
Hi all, sorry for missing this here -- the googleapis repo owners will not be taking on Bzlmod migration work. Instead, the community has settled around maintaining patches on the BCR directly -- see https://registry.bazel.build/modules/googleapis. We should probably close this PR. |
|
See more details in bazelbuild/bazel-central-registry#3472, we believe the new approach will simplify the use of googleapis with Bzlmod and avoid polluting your dependency graph. |
This depends on bazelbuild/bazel-central-registry#1699 because of a circular dependency on grpc-java
This is based on #855 with some fixes