Skip to content

Commit cde1a53

Browse files
Google APIscopybara-github
authored andcommitted
chore: removing parameter before client library generation
PiperOrigin-RevId: 831881099
1 parent 5342712 commit cde1a53

File tree

3 files changed

+32
-115
lines changed

3 files changed

+32
-115
lines changed

google/shopping/merchant/products/v1beta/productinputs.proto

Lines changed: 17 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -25,29 +25,25 @@ import "google/protobuf/field_mask.proto";
2525
import "google/shopping/merchant/products/v1beta/products_common.proto";
2626
import "google/shopping/type/types.proto";
2727

28-
option csharp_namespace = "Google.Shopping.Merchant.Products.V1Beta";
2928
option go_package = "cloud.google.com/go/shopping/merchant/products/apiv1beta/productspb;productspb";
3029
option java_multiple_files = true;
3130
option java_outer_classname = "ProductInputsProto";
3231
option java_package = "com.google.shopping.merchant.products.v1beta";
33-
option php_namespace = "Google\\Shopping\\Merchant\\Products\\V1beta";
34-
option ruby_package = "Google::Shopping::Merchant::Products::V1beta";
3532

3633
// Service to use ProductInput resource.
34+
// This service works for products with online channel only.
3735
service ProductInputsService {
3836
option (google.api.default_host) = "merchantapi.googleapis.com";
3937
option (google.api.oauth_scopes) = "https://www.googleapis.com/auth/content";
4038

4139
// [Uploads a product input to your Merchant Center
42-
// account](/merchant/api/guides/products/add-manage#add_a_product). You
43-
// must have a products [data
44-
// source](/merchant/api/guides/data-sources/api-sources#create-primary-data-source)
45-
// to be able to insert a product. The unique identifier of the data source is
46-
// passed as a query parameter in the request URL.
40+
// account](/merchant/api/guides/products/overview#upload-product-input). You
41+
// must have a products data source to be able to insert a product. The unique
42+
// identifier of the data source is passed as a query parameter in the request
43+
// URL.
4744
//
48-
// If a product input with the same contentLanguage, offerId, and dataSource
49-
// already exists, then the product input inserted by this method replaces
50-
// that entry.
45+
// If an input with the same contentLanguage, offerId, and dataSource already
46+
// exists, this method replaces that entry.
5147
//
5248
// After inserting, updating, or deleting a product input, it may take several
5349
// minutes before the processed product can be retrieved.
@@ -119,14 +115,10 @@ message ProductInput {
119115

120116
// Identifier. The name of the product input.
121117
// Format: `accounts/{account}/productInputs/{productinput}`
122-
// where the last section `productinput` consists of:
123-
// `content_language~feed_label~offer_id`
118+
// where the last section `productinput` consists of 4 parts:
119+
// `channel~content_language~feed_label~offer_id`
124120
// example for product input name is
125-
// `accounts/123/productInputs/en~US~sku123`. A legacy local product input
126-
// name would be `accounts/123/productInputs/local~en~US~sku123`.
127-
// Note: For calls to the v1beta version, the `productInput` section consists
128-
// of: `channel~content_language~feed_label~offer_id`, for example:
129-
// `accounts/123/productInputs/online~en~US~sku123`.
121+
// `accounts/123/productInputs/online~en~US~sku123`
130122
string name = 1 [(google.api.field_behavior) = IDENTIFIER];
131123

132124
// Output only. The name of the processed product.
@@ -158,8 +150,8 @@ message ProductInput {
158150
(google.api.field_behavior) = IMMUTABLE
159151
];
160152

161-
// Required. Immutable. The feed label that lets you categorize and identify
162-
// your products. The maximum allowed characters are 20, and the supported
153+
// Required. Immutable. The label that lets you categorize and identify your
154+
// products. The maximum allowed characters are 20, and the supported
163155
// characters are `A-Z`, `0-9`, hyphen, and underscore. The feed label must
164156
// not include any spaces. For more information, see [Using feed
165157
// labels](//support.google.com/merchants/answer/14994087).
@@ -223,8 +215,8 @@ message InsertProductInputRequest {
223215
// Required. The primary or supplemental product data source name. If the
224216
// product already exists and data source provided is different, then the
225217
// product will be moved to a new data source. For more information, see
226-
// [Create a primary data
227-
// source](/merchant/api/guides/data-sources/api-sources#create-primary-data-source).
218+
// [Overview of Data sources
219+
// sub-API](/merchant/api/guides/data-sources/overview).
228220
//
229221
// Only API data sources are supported.
230222
//
@@ -268,30 +260,16 @@ message UpdateProductInputRequest {
268260
// Format: `accounts/{account}/dataSources/{datasource}`. For example,
269261
// `accounts/123456/dataSources/104628`.
270262
string data_source = 3 [(google.api.field_behavior) = REQUIRED];
271-
272-
// Optional. If true, the `{productInput}` in the `name` field of the request
273-
// will be interpreted as unpadded base64url-encoded and decoded during
274-
// request processing to match the decoded value. Default value is `false`.
275-
// Use this if your `{productInput}` contains special characters, such as
276-
// forward slash
277-
// `/` or other characters that are unpadded base64url-encoded (as per RFC
278-
// 7515: https://datatracker.ietf.org/doc/html/rfc7515#section-2).
279-
//
280-
// Note that future versions of the API will only accept unpadded
281-
// base64url-encoded product ids, so we strongly recommend proactively setting
282-
// this to `true` and encoding the product ids.
283-
bool product_id_base64_url_encoded = 4
284-
[(google.api.field_behavior) = OPTIONAL];
285263
}
286264

287265
// Request message for the DeleteProductInput method.
288266
message DeleteProductInputRequest {
289267
// Required. The name of the product input resource to delete.
290268
// Format: `accounts/{account}/productInputs/{product}`
291-
// where the last section `product` consists of:
292-
// `content_language~feed_label~offer_id`
269+
// where the last section `product` consists of 4 parts:
270+
// `channel~content_language~feed_label~offer_id`
293271
// example for product name is
294-
// `accounts/123/productInputs/en~US~sku123`.
272+
// `accounts/123/productInputs/online~en~US~sku123`.
295273
string name = 1 [
296274
(google.api.field_behavior) = REQUIRED,
297275
(google.api.resource_reference) = {
@@ -304,18 +282,4 @@ message DeleteProductInputRequest {
304282
// `accounts/{account}/dataSources/{datasource}`. For example,
305283
// `accounts/123456/dataSources/104628`.
306284
string data_source = 2 [(google.api.field_behavior) = REQUIRED];
307-
308-
// Optional. If true, the `{productInput}` in the `name` field of the request
309-
// will be interpreted as unpadded base64url-encoded and decoded during
310-
// request processing to match the decoded value. Default value is `false`.
311-
// Use this if your `{productInput}` contains special characters, such as
312-
// forward slash
313-
// `/` or other characters that are unpadded base64url-encoded (as per RFC
314-
// 7515: https://datatracker.ietf.org/doc/html/rfc7515#section-2).
315-
//
316-
// Note that future versions of the API will only accept unpadded
317-
// base64url-encoded product ids, so we strongly recommend proactively setting
318-
// this to `true` and encoding the product ids.
319-
bool product_id_base64_url_encoded = 3
320-
[(google.api.field_behavior) = OPTIONAL];
321285
}

google/shopping/merchant/products/v1beta/products.proto

Lines changed: 9 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,10 @@ import "google/api/resource.proto";
2323
import "google/shopping/merchant/products/v1beta/products_common.proto";
2424
import "google/shopping/type/types.proto";
2525

26-
option csharp_namespace = "Google.Shopping.Merchant.Products.V1Beta";
2726
option go_package = "cloud.google.com/go/shopping/merchant/products/apiv1beta/productspb;productspb";
2827
option java_multiple_files = true;
2928
option java_outer_classname = "ProductsProto";
3029
option java_package = "com.google.shopping.merchant.products.v1beta";
31-
option php_namespace = "Google\\Shopping\\Merchant\\Products\\V1beta";
32-
option ruby_package = "Google::Shopping::Merchant::Products::V1beta";
3330
option (google.api.resource_definition) = {
3431
type: "merchantapi.googleapis.com/Account"
3532
pattern: "accounts/{account}"
@@ -87,13 +84,9 @@ message Product {
8784
// The name of the product.
8885
// Format:
8986
// `accounts/{account}/products/{product}` where the last
90-
// section `product` consists of:
91-
// `content_language~feed_label~offer_id`
92-
// example for product name is `accounts/123/products/en~US~sku123`. A legacy
93-
// local product name would be `accounts/123/products/local~en~US~sku123`.
94-
// Note: For calls to the v1beta version, the `product` section consists
95-
// of: `channel~content_language~feed_label~offer_id`, for example:
96-
// `accounts/123/products/online~en~US~sku123`.
87+
// section `product` consists of 4 parts:
88+
// `channel~content_language~feed_label~offer_id`
89+
// example for product name is `accounts/123/products/online~en~US~sku123`
9790
string name = 1;
9891

9992
// Output only. The
@@ -164,34 +157,17 @@ message Product {
164157
// Request message for the GetProduct method.
165158
message GetProductRequest {
166159
// Required. The name of the product to retrieve.
167-
// Format:
168-
// `accounts/{account}/products/{product}` where the last
169-
// section `product` consists of:
170-
// `content_language~feed_label~offer_id`
171-
// example for product name is `accounts/123/products/en~US~sku123`. A legacy
172-
// local product name would be `accounts/123/products/local~en~US~sku123`.
173-
// Note: For calls to the v1beta version, the `product` section consists
174-
// of: `channel~content_language~feed_label~offer_id`, for example:
175-
// `accounts/123/products/online~en~US~sku123`.
160+
// Format: `accounts/{account}/products/{product}`
161+
// where the last section `product` consists of 4 parts:
162+
// `channel~content_language~feed_label~offer_id`
163+
// example for product name is
164+
// `accounts/123/products/online~en~US~sku123`
176165
string name = 1 [
177166
(google.api.field_behavior) = REQUIRED,
178167
(google.api.resource_reference) = {
179168
type: "merchantapi.googleapis.com/Product"
180169
}
181170
];
182-
183-
// Optional. If true, the `{product}` in the `name` field of the request will
184-
// be interpreted as unpadded base64url-encoded and decoded during request
185-
// processing to match the decoded value. Default value is `false`. Use this
186-
// if your `{product}` contains special characters, such as forward slash `/`
187-
// or other characters that are unpadded base64url-encoded (as per RFC 7515:
188-
// https://datatracker.ietf.org/doc/html/rfc7515#section-2).
189-
//
190-
// Note that future versions of the API will only accept unpadded
191-
// base64url-encoded product ids, so we strongly recommend proactively setting
192-
// this to `true` and encoding the product ids.
193-
bool product_id_base64_url_encoded = 2
194-
[(google.api.field_behavior) = OPTIONAL];
195171
}
196172

197173
// Request message for the ListProducts method.
@@ -208,7 +184,7 @@ message ListProductsRequest {
208184
// The maximum number of products to return. The service may return fewer than
209185
// this value.
210186
// The maximum value is 1000; values above 1000 will be coerced to 1000.
211-
// If unspecified, the default page size of 25 products will be returned.
187+
// If unspecified, the maximum number of products will be returned.
212188
int32 page_size = 2;
213189

214190
// A page token, received from a previous `ListProducts` call.

google/shopping/merchant/products/v1beta/products_common.proto

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,10 @@ import "google/protobuf/timestamp.proto";
2121
import "google/shopping/type/types.proto";
2222
import "google/type/interval.proto";
2323

24-
option csharp_namespace = "Google.Shopping.Merchant.Products.V1Beta";
2524
option go_package = "cloud.google.com/go/shopping/merchant/products/apiv1beta/productspb;productspb";
2625
option java_multiple_files = true;
2726
option java_outer_classname = "ProductsCommonProto";
2827
option java_package = "com.google.shopping.merchant.products.v1beta";
29-
option php_namespace = "Google\\Shopping\\Merchant\\Products\\V1beta";
30-
option ruby_package = "Google::Shopping::Merchant::Products::V1beta";
3128

3229
// The subscription period of the product.
3330
enum SubscriptionPeriod {
@@ -135,7 +132,7 @@ message Attributes {
135132
// Deprecated: Use `gtins` instead.
136133
repeated string gtin = 26 [deprecated = true];
137134

138-
// A list of Global Trade Item Numbers
135+
// Global Trade Item Numbers
139136
// ([GTIN](https://support.google.com/merchants/answer/188494#gtin)) of the
140137
// item.
141138
// You can provide up to 10 GTINs.
@@ -285,7 +282,7 @@ message Attributes {
285282
// The number of identical products in a business-defined multipack.
286283
optional int64 multipack = 58;
287284

288-
// Used to group items in an arbitrary way. Only for CPA, discouraged
285+
// Used to group items in an arbitrary way. Only for CPA%, discouraged
289286
// otherwise. For more information, see
290287
// [Display ads
291288
// attribute](https://support.google.com/merchants/answer/6069387).
@@ -368,9 +365,6 @@ message Attributes {
368365
// custom grouping of items in a Shopping campaign.
369366
optional string custom_label_4 = 75;
370367

371-
// Destinations also known as [Marketing
372-
// methods](https://support.google.com/merchants/answer/15130232) selections.
373-
//
374368
// The list of destinations to include for this target (corresponds to
375369
// checked check boxes in Merchant Center). Default destinations are always
376370
// included unless provided in `excludedDestinations`.
@@ -383,9 +377,6 @@ message Attributes {
383377
// cases. Use this field within products to only setup exceptions.
384378
repeated string included_destinations = 76;
385379

386-
// Destinations also known as [Marketing
387-
// methods](https://support.google.com/merchants/answer/15130232) selections.
388-
//
389380
// The list of destinations to exclude for this target (corresponds to
390381
// unchecked check boxes in Merchant Center).
391382
//
@@ -442,10 +433,10 @@ message Attributes {
442433

443434
// A safeguard in the [automated discounts]
444435
// (https://support.google.com/merchants/answer/10295759) and
445-
// ["dynamic
446-
// promotions"](https://support.google.com/merchants/answer/13949249)
447-
// projects, ensuring that discounts on business offers do not fall below this
448-
// value, thereby preserving the offer's value and profitability.
436+
// "Dynamic Promotions"
437+
// (https://support.google.com/merchants/answer/13949249) projects,
438+
// ensuring that discounts on business offers do not fall below this value,
439+
// thereby preserving the offer's value and profitability.
449440
google.shopping.type.Price auto_pricing_min_price = 124;
450441

451442
// The list of sustainability incentive programs.
@@ -680,20 +671,6 @@ message Shipping {
680671
// [maxTransitTime][google.shopping.merchant.products.v1beta.Shipping.max_transit_time]
681672
// is present.
682673
optional int64 max_transit_time = 11;
683-
684-
// The handling cutoff time until which an order has to be placed to be
685-
// processed in the same day. This is a string in format of HHMM (e.g.
686-
// `1530`) for 3:30 PM. If not configured, the cutoff time will be defaulted
687-
// to 8AM PST and `handling_cutoff_timezone` will be ignored.
688-
optional string handling_cutoff_time = 12;
689-
690-
// [Timezone
691-
// identifier](https://developers.google.com/adwords/api/docs/appendix/codes-formats#timezone-ids)
692-
// For example `Europe/Zurich`. This field only applies if
693-
// `handling_cutoff_time` is set. If `handling_cutoff_time` is set but this
694-
// field is not set, the shipping destination timezone will be used. If both
695-
// fields are not set, the handling cutoff time will default to 8AM PST.
696-
optional string handling_cutoff_timezone = 13;
697674
}
698675

699676
// Conditions to be met for a product to have free shipping.

0 commit comments

Comments
 (0)