Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Fix: Correctly calculate starting offset for retries of ranged reads#450

Merged
andrewsg merged 1 commit intomainfrom
resume-on-retry-from-offset
Aug 7, 2024
Merged

Fix: Correctly calculate starting offset for retries of ranged reads#450
andrewsg merged 1 commit intomainfrom
resume-on-retry-from-offset

Conversation

@andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Aug 7, 2024

Fixes #446 🦕

cc: @shunping, @wilson1yan

@andrewsg andrewsg requested a review from a team as a code owner August 7, 2024 21:39
@andrewsg andrewsg requested a review from a team August 7, 2024 21:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/google-resumable-media-python API. labels Aug 7, 2024
Copy link

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewsg andrewsg merged commit 34302b4 into main Aug 7, 2024
@andrewsg andrewsg deleted the resume-on-retry-from-offset branch August 7, 2024 22:07
@shunping
Copy link

shunping commented Aug 9, 2024

Thanks for the fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/google-resumable-media-python API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect start offset when range reads are interrupted

4 participants