Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: handle interrupted downloads with decompressive transcoding#346

Merged
cojenco merged 6 commits intogoogleapis:mainfrom
cojenco:303gzip
Sep 21, 2022
Merged

feat: handle interrupted downloads with decompressive transcoding#346
cojenco merged 6 commits intogoogleapis:mainfrom
cojenco:303gzip

Conversation

@cojenco
Copy link
Copy Markdown
Contributor

@cojenco cojenco commented Aug 15, 2022 •
edited
Loading

Handle interrupted downloads with decompressive transcoding

  • distinguish if transcoding occured by the newly introduced headers x-goog-stored-content-encoding and x-goog-stored-content-length in the JSON API 🎉
  • check edge case in which the object is served as-is without decompression along with response header content-encoding: gzip
  • reset the stream position for retried range requests if decompressive transcoding occurred (GCS serves back the entire file)

Fixes #303 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/google-resumable-media-python API. labels Aug 15, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2022
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@cojenco cojenco marked this pull request as ready for review August 26, 2022 22:08
@cojenco cojenco requested a review from a team as a code owner August 26, 2022 22:08
@cojenco cojenco requested a review from a team August 26, 2022 22:08
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2022
@cojenco cojenco requested a review from frankyn August 29, 2022 17:53
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2022
frankyn
frankyn suggested changes Sep 15, 2022
View reviewed changes
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2022
@cojenco cojenco requested a review from frankyn September 20, 2022 18:22
@cojenco cojenco merged commit f4d26b7 into googleapis:main Sep 21, 2022
@release-please release-please bot mentioned this pull request Sep 21, 2022
Merged
@frankyn frankyn mentioned this pull request Jan 7, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@frankyn frankyn

Labels

api: storage Issues related to the googleapis/google-resumable-media-python API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle retries in decompressive transcoding downloads

4 participants

@cojenco @frankyn @parthea @yoshi-kokoro