Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

chore(deps): update doctest#341

Merged
cojenco merged 3 commits into
mainfrom
dandhlee-patch-1
Jul 14, 2022
Merged

chore(deps): update doctest#341
cojenco merged 3 commits into
mainfrom
dandhlee-patch-1

Conversation

@dandhlee

@dandhlee dandhlee commented Jul 14, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass

Fixes #340 🦕

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/google-resumable-media-python API. labels Jul 14, 2022
@dandhlee dandhlee changed the title chore: pin sphinx to use v4 instead of v5 chore(deps): pin sphinx to use v4 instead of v5 Jul 14, 2022
@dandhlee dandhlee marked this pull request as ready for review July 14, 2022 04:02
@dandhlee dandhlee requested review from a team July 14, 2022 04:02
@dandhlee dandhlee changed the title chore(deps): pin sphinx to use v4 instead of v5 chore(deps): update doctest Jul 14, 2022
@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2022

@cojenco cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Dan for working on this!

@cojenco cojenco merged commit 212728a into main Jul 14, 2022
@cojenco cojenco deleted the dandhlee-patch-1 branch July 14, 2022 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/google-resumable-media-python API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests failing due to doctest using sphinx v5

2 participants