feat: add configurable crc32c checksumming for downloads #135
Conversation
|
Received a design suggestion to move the argument to the class constructor for the download class; looking into refactoring that now. |
frankyn
left a comment
There was a problem hiding this comment.
Overall, I think it LGTM, added a few comments for changes.
|
@frankyn PTAL |
|
Fixed merge conflict and addressed comments. |
frankyn
left a comment
There was a problem hiding this comment.
I missed a potential refactor, adding that in.
|
Thanks for the suggestion, I was able to remove some duplication of code between Download and RawDownload and tighten it up a bit in general. PTAL |
frankyn
left a comment
There was a problem hiding this comment.
I have one more question on crc32c support for google-crc32c and how users are being warned.
Thanks for the refactor, it looks much cleaner!
|
@frankyn fixed coverage issue; PTAL |
frankyn
left a comment
There was a problem hiding this comment.
LGTM, thanks @andrewsg,
pending kokoro failure:
Formatting issue:
flake8 google/resumable_media tests
black --check google/resumable_media tests
would reformat /tmpfs/src/github/google-resumable-media-python/tests/unit/requests/test_download.py
Oh no! 💥 💔 💥
1 file would be reformatted, 24 files would be left unchanged.
No description provided.