Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

feat: add support for concurrent XML MPU uploads#395

Merged
andrewsg merged 18 commits into
mainfrom
mpu
Sep 6, 2023
Merged

feat: add support for concurrent XML MPU uploads#395
andrewsg merged 18 commits into
mainfrom
mpu

Conversation

@andrewsg

@andrewsg andrewsg commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@andrewsg andrewsg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 16, 2023
@andrewsg andrewsg requested review from a team August 16, 2023 01:01
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: storage Issues related to the googleapis/google-resumable-media-python API. labels Aug 16, 2023

@cojenco cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for MPU🎉 Making my way through the PR and have a few questions

Comment thread google/resumable_media/_upload.py
Comment thread google/resumable_media/_upload.py
Comment thread google/resumable_media/_upload.py
Comment thread google/resumable_media/_upload.py Outdated
Comment thread google/resumable_media/_upload.py
Comment thread google/resumable_media/_upload.py Outdated
Comment thread google/resumable_media/requests/upload.py Outdated
Comment thread tests/unit/test__upload.py
Comment thread tests/unit/test__upload.py Outdated
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 31, 2023
@andrewsg andrewsg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 31, 2023
@andrewsg

Copy link
Copy Markdown
Contributor Author

PTAL

@cojenco cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment thread google/resumable_media/_upload.py
Comment thread google/resumable_media/_upload.py Outdated
Comment thread google/resumable_media/_upload.py
@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Sep 6, 2023
@gcf-merge-on-green

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 6, 2023
@andrewsg andrewsg merged commit a8d56bc into main Sep 6, 2023
@andrewsg andrewsg deleted the mpu branch September 6, 2023 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/google-resumable-media-python API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants