Skip to content

chore: troubleshooting lint problem#1508

Closed
suztomo wants to merge 1 commit intogoogleapis:mainfrom
suztomo:fix_lint
Closed

chore: troubleshooting lint problem#1508
suztomo wants to merge 1 commit intogoogleapis:mainfrom
suztomo:fix_lint

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Nov 23, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@suztomo suztomo requested a review from a team November 23, 2021 16:57
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/build.sh

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2021
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 23, 2021

It succeeded.

Screen Shot 2021-11-23 at 12 11 40 PM

@suztomo suztomo closed this Nov 23, 2021
@suztomo suztomo reopened this Nov 23, 2021
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2021
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 23, 2021

This is what fmt-maven-plugin suggests:

~/google-http-java-client $ mvn com.coveo:fmt-maven-plugin:format
...
~/google-http-java-client $ git diff                                                                       git[branch:fix_lint]
diff --git a/google-http-client/src/test/java/com/google/api/client/http/HttpRequestTracingTest.java b/google-http-client/src/test/java/com/google/api/client/http/HttpRequestTracingTest.java
index 6fc9cb37..9618be79 100644
--- a/google-http-client/src/test/java/com/google/api/client/http/HttpRequestTracingTest.java
+++ b/google-http-client/src/test/java/com/google/api/client/http/HttpRequestTracingTest.java
@@ -44,9 +44,7 @@ public class HttpRequestTracingTest {
   public void setupTestTracer() {
     Tracing.getExportComponent().getSpanExporter().registerHandler("test", testHandler);
     TraceParams params =
-        Tracing.getTraceConfig()
-            .getActiveTraceParams()
-            .toBuilder()
+        Tracing.getTraceConfig().getActiveTraceParams().toBuilder()
             .setSampler(Samplers.alwaysSample())
             .build();
     Tracing.getTraceConfig().updateActiveTraceParams(params);

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 23, 2021

Continuing in googleapis/synthtool#1288

@suztomo suztomo closed this Nov 23, 2021
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Sep 1, 2022

googleapis/synthtool#1288 was reverted.

@suztomo suztomo mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant