FileDataStoreFactory fails inconsistently when setting permissions #1011
Description
Discovered in #927
public FileDataStoreFactory(File dataDirectory) throws IOException {
dataDirectory = dataDirectory.getCanonicalFile();
this.dataDirectory = dataDirectory;
// error if it is a symbolic link
if (IOUtils.isSymbolicLink(dataDirectory)) {
throw new IOException("unable to use a symbolic link: " + dataDirectory);
}
// create parent directory (if necessary)
if (!dataDirectory.exists() && !dataDirectory.mkdirs()) {
throw new IOException("unable to create directory: " + dataDirectory);
}
if (IS_WINDOWS) {
setPermissionsToOwnerOnlyWindows(dataDirectory);
} else {
setPermissionsToOwnerOnly(dataDirectory);
}
}
setPermissionsToOwnerOnlyWindows and setPermissionsToOwnerOnly have several possible failure modes (i.e. exceptions thrown). Some of these are bubbled and some of these are eaten.
We need a consistent decision on whether failing to set permissions to owner only is or is not a fatal error. Whichever we decide we need to change the code to implement that on all paths.