Skip to content

impl(storage): add spans to ObjectDescriptor::read_range#5183

Merged
coryan merged 3 commits intogoogleapis:mainfrom
coryan:impl-storage-open-object-o11y
Mar 29, 2026
Merged

impl(storage): add spans to ObjectDescriptor::read_range#5183
coryan merged 3 commits intogoogleapis:mainfrom
coryan:impl-storage-open-object-o11y

Conversation

@coryan
Copy link
Copy Markdown
Collaborator

@coryan coryan commented Mar 29, 2026

An object descriptor may be used in multiple read_range() operations.
Application developers will be interested in the performance of these
calls.

Fixes #3178

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 29, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.91667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.94%. Comparing base (dc6e9c4) to head (b7a6aac).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/transport.rs 96.84% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5183      +/-   ##
==========================================
- Coverage   97.94%   97.94%   -0.01%     
==========================================
  Files         217      217              
  Lines       43526    43670     +144     
==========================================
+ Hits        42632    42773     +141     
- Misses        894      897       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan
impl(storage): add spans to ObjectDescriptor::read_range
51bbbab 
An object descriptor may be used in multiple `read_range()` operations.
Application developers will be interested in the performance of these
calls.
@coryan coryan force-pushed the impl-storage-open-object-o11y branch from 4a81389 to 51bbbab Compare March 29, 2026 18:57
@coryan coryan marked this pull request as ready for review March 29, 2026 19:44
@coryan coryan requested a review from a team as a code owner March 29, 2026 19:44
westarle
westarle approved these changes Mar 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@westarle westarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have a link with the resulting spans? I'm curious about their relationship to CLIENT spans.

@coryan
Copy link
Copy Markdown
Collaborator Author

coryan commented Mar 29, 2026

do you have a link with the resulting spans? I'm curious about their relationship to CLIENT spans.

Look at the read_range spans in:

https://console.cloud.google.com/traces/explorer;traceId=adcf64362227220daae829ebdb6d93d4?project=coryan-test

They are unconnected to the client span... That might be a good improvement for the future: @joshuatants FYI

@coryan coryan enabled auto-merge (squash) March 29, 2026 20:42
@coryan coryan merged commit 828180a into googleapis:main Mar 29, 2026
36 checks passed
@coryan coryan deleted the impl-storage-open-object-o11y branch March 29, 2026 20:51
@westarle
Copy link
Copy Markdown
Contributor

westarle commented Mar 29, 2026

They are unconnected to the client span... That might be a good improvement for the future: @joshuatants FYI

Let's chat about it sometime, I think it is a good thing that they aren't hierarchically related for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westarle westarle westarle approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracing for Storage client

2 participants

@coryan @westarle