Skip to content

feat(pubsub): configure subscriber shutdown behavior#5064

Merged
dbolduc merged 2 commits intogoogleapis:mainfrom
dbolduc:feat-pubsub-shutdown-behavior
Mar 23, 2026
Merged

feat(pubsub): configure subscriber shutdown behavior#5064
dbolduc merged 2 commits intogoogleapis:mainfrom
dbolduc:feat-pubsub-shutdown-behavior

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Mar 18, 2026

Fixes #4868

Add a builder option to configure shutdown.

We use a builder option so that the application can define the behavior on external shutdowns (e.g. a permanent midstream error).

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Mar 18, 2026
@dbolduc dbolduc marked this pull request as ready for review March 19, 2026 03:28
@dbolduc dbolduc requested a review from a team as a code owner March 19, 2026 03:28
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (f347f78) to head (0c5a4df).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5064   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files         230      230           
  Lines        8797     8801    +4     
=======================================
+ Hits         8082     8086    +4     
  Misses        715      715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc merged commit 5b63641 into googleapis:main Mar 23, 2026
35 checks passed
@dbolduc dbolduc deleted the feat-pubsub-shutdown-behavior branch March 23, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subscriber configurable shutdown behavior

3 participants