Skip to content

feat(pubsub): add exactly once delivery in Subscriber#5032

Merged
PhongChuong merged 5 commits intogoogleapis:mainfrom
PhongChuong:subMessageStream
Mar 17, 2026
Merged

feat(pubsub): add exactly once delivery in Subscriber#5032
PhongChuong merged 5 commits intogoogleapis:mainfrom
PhongChuong:subMessageStream

Conversation

@PhongChuong
Copy link
Copy Markdown
Collaborator

@PhongChuong PhongChuong commented Mar 16, 2026 •
edited
Loading

Towards #3964

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Mar 16, 2026
@PhongChuong PhongChuong changed the title feat(pubsub): add exactly once in Subscriber feat(pubsub): add exactly once delivery in Subscriber Mar 16, 2026
dbolduc
dbolduc reviewed Mar 16, 2026
View reviewed changes
@PhongChuong
Copy link
Copy Markdown
Collaborator Author

PhongChuong commented Mar 16, 2026

@dbolduc , thanks for the review. PTAL.

dbolduc
dbolduc approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dbolduc
Copy link
Copy Markdown
Member

dbolduc commented Mar 16, 2026

Is the only thing left to remove the #[allow(dead_code)] // TODO(#3964) ... stuff?

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.68%. Comparing base (6fc1d41) to head (51cedca).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5032      +/-   ##
==========================================
+ Coverage   92.66%   92.68%   +0.01%     
==========================================
  Files         226      226              
  Lines        8688     8696       +8     
==========================================
+ Hits         8051     8060       +9     
+ Misses        637      636       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PhongChuong PhongChuong marked this pull request as ready for review March 17, 2026 16:57
@PhongChuong PhongChuong requested a review from a team as a code owner March 17, 2026 16:57
dbolduc
dbolduc approved these changes Mar 17, 2026
View reviewed changes
@PhongChuong
Copy link
Copy Markdown
Collaborator Author

PhongChuong commented Mar 17, 2026

@dbolduc , thanks for the review. PTAL.

Is the only thing left to remove the #[allow(dead_code)] // TODO(#3964) ... stuff?

Yep. I believe so.

@PhongChuong PhongChuong merged commit 9be8a99 into googleapis:main Mar 17, 2026
35 checks passed
@PhongChuong PhongChuong mentioned this pull request Mar 17, 2026
Merged
@olavloite olavloite mentioned this pull request Mar 18, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PhongChuong @dbolduc