feat(pubsub): configurable max lease#5005
Merged
dbolduc merged 1 commit intogoogleapis:mainfrom Mar 16, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5005 +/- ##
==========================================
+ Coverage 92.66% 92.68% +0.01%
==========================================
Files 226 226
Lines 8688 8693 +5
==========================================
+ Hits 8051 8057 +6
+ Misses 637 636 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suzmue
approved these changes
Mar 13, 2026
ffefd1e to
281eb87
Compare
Member
Author
|
/gcbrun |
1 similar comment
Member
Author
|
/gcbrun |
Member
Author
|
welp, I guess I'll just try again |
Member
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4947
Let applications configure the max lease time - how long the client extends a message lease for before giving up.
nit: I am not overly concerned, about the hold time falling in the range of
[max_lease, max_lease + max_lease_extension].