Skip to content

feat(storage): Add method to disable checksums on read object#4993

Merged
vsharonlynn merged 9 commits intogoogleapis:mainfrom
vsharonlynn:feat/storage-disable-checksum
Mar 17, 2026
Merged

feat(storage): Add method to disable checksums on read object#4993
vsharonlynn merged 9 commits intogoogleapis:mainfrom
vsharonlynn:feat/storage-disable-checksum

Conversation

@vsharonlynn
Copy link
Copy Markdown
Contributor

For issue #4285.

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 12, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.64%. Comparing base (9af8df4) to head (0eb85a7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/read_object.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4993      +/-   ##
==========================================
- Coverage   92.65%   92.64%   -0.01%     
==========================================
  Files         226      226              
  Lines        8695     8703       +8     
==========================================
+ Hits         8056     8063       +7     
- Misses        639      640       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by, as I may not be available tomorrow.

@vsharonlynn vsharonlynn force-pushed the feat/storage-disable-checksum branch 3 times, most recently from 1759962 to 79e3754 Compare March 16, 2026 06:38
@vsharonlynn vsharonlynn marked this pull request as ready for review March 16, 2026 07:09
@vsharonlynn vsharonlynn requested a review from a team as a code owner March 16, 2026 07:09
@vsharonlynn vsharonlynn dismissed joshuatants’s stale review March 16, 2026 07:10

Sorry, dismissing this because I can't see this after rebasing to latest main. PTAL at the latest version. Thank you.

@vsharonlynn vsharonlynn force-pushed the feat/storage-disable-checksum branch from a73793c to 869f2b6 Compare March 17, 2026 02:50
@vsharonlynn vsharonlynn force-pushed the feat/storage-disable-checksum branch from 9390b0c to 0eb85a7 Compare March 17, 2026 14:10
@vsharonlynn vsharonlynn enabled auto-merge (squash) March 17, 2026 14:11
@vsharonlynn vsharonlynn merged commit 7623628 into googleapis:main Mar 17, 2026
35 checks passed
@vsharonlynn vsharonlynn deleted the feat/storage-disable-checksum branch March 19, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants