Skip to content

cleanup(pubsub)!: clarify deadline extension option#4949

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:cleanup-pubsub-bang-ack-deadline-seconds
Mar 9, 2026
Merged

cleanup(pubsub)!: clarify deadline extension option#4949
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:cleanup-pubsub-bang-ack-deadline-seconds

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Mar 9, 2026

Fixes #4134 fixes #4948

@dbolduc dbolduc marked this pull request as ready for review March 9, 2026 17:27
@dbolduc dbolduc requested a review from a team as a code owner March 9, 2026 17:27
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.94%. Comparing base (75bbe0c) to head (bdce258).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4949   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files         221      221           
  Lines        8538     8538           
=======================================
  Hits         8021     8021           
  Misses        517      517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc merged commit 1feb8f2 into googleapis:main Mar 9, 2026
35 checks passed
@dbolduc dbolduc deleted the cleanup-pubsub-bang-ack-deadline-seconds branch March 9, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename set_ack_deadline_seconds Clamp ack deadline seconds in subscriber?

2 participants